Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert: Back out duplicated tests for duplicate path parameter rule #115

Merged
merged 1 commit into from
Nov 22, 2019
Merged

revert: Back out duplicated tests for duplicate path parameter rule #115

merged 1 commit into from
Nov 22, 2019

Conversation

mkistler
Copy link
Contributor

This PR backs out duplicated tests for the duplicate path parameter rule.

@codecov
Copy link

codecov bot commented Nov 21, 2019 •
edited
Loading

Codecov Report

Merging #115 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #115   +/-   ##
=======================================
  Coverage   92.37%   92.37%           
=======================================
  Files          55       55           
  Lines        1968     1968           
=======================================
  Hits         1818     1818           
  Misses        150      150

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61b0bb7...6b0e72a. Read the comment docs.

dpopp07
dpopp07 approved these changes Nov 21, 2019
View reviewed changes
Copy link
Member

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@mkistler mkistler merged commit 4d58a82 into master Nov 22, 2019
@mkistler mkistler deleted the mdk/revert branch November 22, 2019 13:13
dpopp07 pushed a commit that referenced this pull request Nov 25, 2019
@semantic-release-bot
chore(release): 0.15.2 [skip ci]
a90f3fc 
## [0.15.2](v0.15.1...v0.15.2) (2019-11-25)

### Bug Fixes

* Fix duplicate parameter checking when all parameters are defined at the path level ([#116](#116)) ([f40bd6f](f40bd6f))

### Reverts

* Back out duplicated tests for duplicate path parameter rule ([#115](#115)) ([4d58a82](4d58a82))
@dpopp07
Copy link
Member

dpopp07 commented Nov 25, 2019

🎉 This PR is included in version 0.15.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpopp07 dpopp07 dpopp07 approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkistler @dpopp07