feat: adds a default warning for 422 and 302 responses #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #154 +/- ##
==========================================
+ Coverage 93.1% 93.11% +0.01%
==========================================
Files 61 61
Lines 2131 2136 +5
==========================================
+ Hits 1984 1989 +5
Misses 147 147
Continue to review full report at Codecov.
|
dpopp07
requested changes
Mar 11, 2020
barrett-schonefeld
force-pushed
the
422-response
branch
from
9fc9061
to
feec9ec
Compare
barrett-schonefeld
changed the title
|
I changed the structure a bit. Since these 302 and 422 warnings are similar, I put the checks in one for-loop rather than in the top level if-else statement. Now the module says, "If no status codes, error. Else, check for discouraged status codes and validate success codes." |
dpopp07
requested changes
Mar 16, 2020
- IBM Handbook says 400 response should be used instead of 422 - IBM Handbook prefers 303 and 307 responses over 302 - added ibm_status_code_guidelines config option with default warning - added a test to ensure warning issued for 422 response - added a test to ensure warning issued for 302 response
barrett-schonefeld
force-pushed
the
422-response
branch
from
feec9ec
to
ccdb9d3
Compare
dpopp07
pushed a commit
that referenced
this pull request
Mar 16, 2020
# [0.26.0](v0.25.0...v0.26.0) (2020-03-16) ### Features * adds a check for 422 and 302 status codes ([#154](#154)) ([4d5ba65](4d5ba65))
|
🎉 This PR is included in version 0.26.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason:
Changes:
Tests