Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cannot find ajv module when ibm:oas ruleset extended #279

Merged
merged 1 commit into from
Apr 14, 2021

Conversation

barrett-schonefeld
Copy link
Contributor

@barrett-schonefeld barrett-schonefeld commented Apr 13, 2021

Purpose:

  • Exception thrown when user creates spectral config that extends ibm:oas. Removes a rule that we want to reintroduce but allows users to extend the ibm:oas ruleset for now.

Changes:

  • Remove the rule that causes this problem.

Fixes #275

Purpose:
- Exception thrown when user creates spectral config that extends ibm:oas. Removes a rule that we want to reintroduce but allows users to extend the ibm:oas ruleset for now.

Changes:
- Remove the rule that causes this problem.
Copy link
Contributor

@mkistler mkistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

Copy link
Member

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for now 👍

Let's make sure we open an internal issue to re-add this later

@barrett-schonefeld barrett-schonefeld merged commit fd2cb29 into main Apr 14, 2021
@barrett-schonefeld barrett-schonefeld deleted the fix-extends-problem branch April 14, 2021 20:15
ibm-devx-sdk pushed a commit that referenced this pull request Apr 14, 2021
## [0.40.2](v0.40.1...v0.40.2) (2021-04-14)

### Bug Fixes

* cannot find ajv module when ibm:oas ruleset extended ([#279](#279)) ([fd2cb29](fd2cb29))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.40.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to customize spectral config: Error: Cannot find module 'ajv'
4 participants