Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 101 and 202 responses do not need content entries #320

Merged
merged 1 commit into from
Sep 13, 2021

Conversation

barrett-schonefeld
Copy link
Contributor

Fixes #298.

Do not warn for missing content field for 101 and 202 responses because these protocols do not require response bodies.

@codecov
Copy link

codecov bot commented Sep 13, 2021

Codecov Report

Merging #320 (fb6fca7) into main (c921293) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #320   +/-   ##
=======================================
  Coverage   91.90%   91.90%           
=======================================
  Files          73       73           
  Lines        2348     2348           
  Branches      598      598           
=======================================
  Hits         2158     2158           
  Misses        157      157           
  Partials       33       33           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c921293...fb6fca7. Read the comment docs.

Copy link
Member

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@dpopp07
Copy link
Member

dpopp07 commented Sep 13, 2021

@meem FYI

@barrett-schonefeld barrett-schonefeld merged commit cdb0e47 into main Sep 13, 2021
@barrett-schonefeld barrett-schonefeld deleted the expand-content-exceptions branch September 13, 2021 19:04
ibm-devx-sdk pushed a commit that referenced this pull request Sep 13, 2021
## [0.47.1](v0.47.0...v0.47.1) (2021-09-13)

### Bug Fixes

* add 101 and 202 responses as exceptions for `content-entry-provided` rule ([#320](#320)) ([cdb0e47](cdb0e47))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.47.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@meem
Copy link
Contributor

meem commented Sep 13, 2021

@dpopp07 @barrett-schonefeld Excellent, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"non-204 responses should define a content object" seems too narrow
4 participants