Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(IAM Access Groups): add support for dynamic membership #179

Merged
merged 2 commits into from
Apr 4, 2022

Conversation

narinder-kaur
Copy link
Member

@narinder-kaur narinder-kaur commented Mar 17, 2022

this Pr includes the changes for dynamic membership in access groups

PR summary

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@CLAassistant
Copy link

CLAassistant commented Mar 17, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ padamstx
❌ Narinder


Narinder seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@narinder-kaur narinder-kaur force-pushed the accessgroup-dynamic-membership-list branch 2 times, most recently from 226d20d to 15b4cb0 Compare March 30, 2022 10:36
@narinder-kaur narinder-kaur force-pushed the accessgroup-dynamic-membership-list branch from 15b4cb0 to 6874ea5 Compare March 30, 2022 10:36
@padamstx padamstx self-requested a review April 1, 2022 19:54
@padamstx padamstx changed the title feature(dynamic-membership): Added dynamic membership supports to access groups feature(IAM Access Groups): add support for dynamic membership Apr 1, 2022
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx
Copy link
Member

padamstx commented Apr 1, 2022

@narinder-kaur Please post screenshots that show clean test results from the integration tests and examples.

@padamstx padamstx self-assigned this Apr 4, 2022
@padamstx padamstx merged commit 73cfc49 into main Apr 4, 2022
@padamstx padamstx deleted the accessgroup-dynamic-membership-list branch April 4, 2022 14:21
padamstx added a commit that referenced this pull request Apr 4, 2022
Co-authored-by: Narinder <narinde.kaur1@ibm.com>
Co-authored-by: Phil Adams <phil_adams@us.ibm.com>
ibm-devx-sdk pushed a commit that referenced this pull request Apr 4, 2022
# [0.23.0](v0.22.11...v0.23.0) (2022-04-04)

### Features

* **IAM Access Groups:** add support for dynamic membership ([#179](#179)) ([f2c9d65](f2c9d65))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants