Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Catalog Management): add missed fields from api definition, remove old Syndication fields #308

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

benbuchanan
Copy link
Contributor

@benbuchanan benbuchanan commented Mar 13, 2024

PR summary

Adding some fields that were missing from the api definition, removing a long deprecated syndication field from catalogs.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Supporting more API parameters

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

…ve old Syndication fields

Signed-off-by: Ben Buchanan <buchanan@ibm.com>
@benbuchanan benbuchanan requested a review from padamstx March 13, 2024 14:03
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx changed the title feat(Catalog Management): add missed fields from api definition, remo… feat(Catalog Management): add missed fields from api definition, remove old Syndication fields Mar 14, 2024
@padamstx padamstx self-assigned this Mar 14, 2024
@padamstx padamstx merged commit 2c2a839 into IBM:main Mar 14, 2024
3 checks passed
ibm-devx-sdk pushed a commit that referenced this pull request Mar 14, 2024
# [0.61.0](v0.60.0...v0.61.0) (2024-03-14)

### Features

* **Catalog Management:** add missed fields from api definition, remove old Syndication fields ([#308](#308)) ([2c2a839](2c2a839))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.61.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

PhaniDivi-613 pushed a commit to PhaniDivi-613/platform-services-go-sdk that referenced this pull request Mar 15, 2024
…ve old Syndication fields (IBM#308)

Signed-off-by: Ben Buchanan <buchanan@ibm.com>
Signed-off-by: Divi-Tiru-Sai-Gopala-Pavana-Phaneendra <divi.tiru.sai.gopala.pavana.phaneendra@ibm.com>
PhaniDivi-613 pushed a commit to PhaniDivi-613/platform-services-go-sdk that referenced this pull request Mar 15, 2024
# [0.61.0](IBM/platform-services-go-sdk@v0.60.0...v0.61.0) (2024-03-14)

### Features

* **Catalog Management:** add missed fields from api definition, remove old Syndication fields ([IBM#308](IBM#308)) ([2c2a839](IBM@2c2a839))

Signed-off-by: Divi-Tiru-Sai-Gopala-Pavana-Phaneendra <divi.tiru.sai.gopala.pavana.phaneendra@ibm.com>
PhaniDivi-613 pushed a commit to PhaniDivi-613/platform-services-go-sdk that referenced this pull request Mar 15, 2024
…ve old Syndication fields (IBM#308)

Signed-off-by: Ben Buchanan <buchanan@ibm.com>
Signed-off-by: Divi-Tiru-Sai-Gopala-Pavana-Phaneendra <divi.tiru.sai.gopala.pavana.phaneendra@ibm.com>
PhaniDivi-613 pushed a commit to PhaniDivi-613/platform-services-go-sdk that referenced this pull request Mar 15, 2024
# [0.61.0](IBM/platform-services-go-sdk@v0.60.0...v0.61.0) (2024-03-14)

### Features

* **Catalog Management:** add missed fields from api definition, remove old Syndication fields ([IBM#308](IBM#308)) ([2c2a839](IBM@2c2a839))

Signed-off-by: Divi-Tiru-Sai-Gopala-Pavana-Phaneendra <divi.tiru.sai.gopala.pavana.phaneendra@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants