Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Context-Based Restrictions): address ID support #344

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

mtbrandy
Copy link
Member

@mtbrandy mtbrandy commented Jul 9, 2024

PR summary

  • add "id" property to zone addresses (for use by terraform only)
  • fix integration test to use valid location

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features) [N/A]

Current vs new behavior

  • support address id property for terraform

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

…form only)

Signed-off-by: Matthew Brandyberry <mbrandy@us.ibm.com>
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx merged commit 239d353 into IBM:main Jul 9, 2024
3 checks passed
ibm-devx-sdk pushed a commit that referenced this pull request Jul 9, 2024
## [0.64.4](v0.64.3...v0.64.4) (2024-07-09)

### Bug Fixes

* **Context-Based Restrictions:** address ID support (for use by terraform only) ([#344](#344)) ([239d353](239d353))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.64.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants