Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use v1 api for image enforcement webhooks. #118

Closed
sjhx opened this issue Jun 7, 2020 · 2 comments · Fixed by #271
Closed

Use v1 api for image enforcement webhooks. #118

sjhx opened this issue Jun 7, 2020 · 2 comments · Fixed by #271
Assignees
@pravarag
Labels
good first issue Good for newcomers requirement not optional

Comments

@sjhx
Copy link
Member

sjhx commented Jun 7, 2020

Kubernetes 1.16 promotes the admissionregistration.k8s.io API to v1. Look at using that for Kubernetes 1.16 and later. In 1.19 the v1beta api is scheduled to be dropped completely.
@sjhx sjhx added the requirement not optional label Jun 24, 2020
@sjhx sjhx added the good first issue Good for newcomers label Jul 2, 2020
@sjhx sjhx mentioned this issue Nov 23, 2020
Closed
@pravarag
Copy link
Contributor

pravarag commented Feb 1, 2021

@sjhx I would like to work on this issue as a new contributor if it's not already taken.

@pravarag pravarag mentioned this issue Feb 22, 2021
Merged
@pravarag
Copy link
Contributor

@sjhx I've raised the PR with following changes as mentioned here: #271
Kindly review and let me know if anymore testing is required for the same.

@sjhx sjhx closed this as completed in #271 Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pravarag pravarag

Labels
good first issue Good for newcomers requirement not optional
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update admissionregistration.k8s.io API to v1 pravarag/portieris
2 participants
@pravarag @sjhx