From eae91468c24263f06ae73dce45eb26252c73b1d6 Mon Sep 17 00:00:00 2001 From: Evan Huus Date: Mon, 26 Feb 2018 09:32:53 -0500 Subject: [PATCH] consumer: don't stop the ticker if we time out Now that we reuse a single ticker the whole time, this would probably lead to the consumer just kind of hanging and never resuming. Thanks to https://github.com/Shopify/sarama/pull/1028#issuecomment-368320469 for catching this. --- consumer.go | 1 - 1 file changed, 1 deletion(-) diff --git a/consumer.go b/consumer.go index e9ccad625..be4e6d4a3 100644 --- a/consumer.go +++ b/consumer.go @@ -461,7 +461,6 @@ feederLoop: child.messages <- msg } child.broker.input <- child - expiryTicker.Stop() continue feederLoop } else { // current message has not been sent, return to select