Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retries and timeout when managing ACLs with the ClusterAdmin #2112

Closed
nkostoulas opened this issue Jan 17, 2022 · 5 comments
Closed

retries and timeout when managing ACLs with the ClusterAdmin #2112

nkostoulas opened this issue Jan 17, 2022 · 5 comments
Labels
bug stale Issues and pull requests without any recent activity

Comments

@nkostoulas
Copy link
Contributor

nkostoulas commented Jan 17, 2022

👋 We're trying to use the ACL methods of the ClusterAdmin and noticed there's no option for retries or timeouts even though these are specified in the Admin part of the Config and are used with Topics related methods. Is there a reason behind this? Can it be assumed that these are less likely to flake or drag on or should we be managing this on our end?

@dnwe
Copy link
Collaborator

dnwe commented Jan 23, 2022

No they're equally likely to hit a condition of ErrNoController so you're correct that they should really be wrappered in a similar ca.retryOnError(isErrNoController, ...) { ... } call

@dnwe dnwe added the bug label Jan 23, 2022
@github-actions

This comment was marked as outdated.

@github-actions github-actions bot added the stale Issues and pull requests without any recent activity label Aug 18, 2023
@dnwe
Copy link
Collaborator

dnwe commented Aug 18, 2023

@hindessm similar to #2520

@dnwe dnwe removed the stale Issues and pull requests without any recent activity label Aug 18, 2023
@hindessm
Copy link
Collaborator

Is it similar though? Looking at KIP-140, it says:

CreateAclsRequest contains a list of ACLs to add. It can be sent to any broker.

and:

Just like CreateAclsRequest, DeleteAclsRequest can be sent to any broker.

I didn't spot an explicit statement regarding the Describe request but I don't imagine that would be more strict.

Copy link

github-actions bot commented Jan 6, 2024

Thank you for taking the time to raise this issue. However, it has not had any activity on it in the past 90 days and will be closed in 30 days if no updates occur.
Please check if the main branch has already resolved the issue since it was raised. If you believe the issue is still valid and you would like input from the maintainers then please comment to ask for it to be reviewed.

@github-actions github-actions bot added the stale Issues and pull requests without any recent activity label Jan 6, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug stale Issues and pull requests without any recent activity
Projects
None yet
Development

No branches or pull requests

3 participants