-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"kafka: response did not contain all the expected topic/partition blocks" out of nowhere? when changing compression #698
Comments
Off the top of my head, https://issues.apache.org/jira/browse/KAFKA-1499 suggests that you should, and that it will all end up uniform on the broker.
That is... surprising. It sounds like you've hit some very peculiar bug in either Sarama or upstream Kafka. I just did a quick skim of our produce-response-parsing code and didn't spot anything, so I would suggest you take a look at the actual broker logs when you try this. Is the broker logging any exceptions? If the Sarama log is accurate then the broker is sending a malformed response and you'll need to take it up with upstream. |
Thanks @eapache FWIW here's all the kafka, zk and supervisor logs https://gist.github.com/Dieterbe/7142236d6828b7bb078c6f0172b543c4 and this is how I'm running it: https://github.com/raintank/raintank-docker/tree/master/kafka if it still looks like an upstream issue to you, i'll take this to https://issues.apache.org/jira/browse/KAFKA/ |
Ya, I'm not sure what the problem is still. You might try inspecting the actual traffic on the wire using a tool like Wireshark to see if the Sarama error message is correct and the broker responses are actually missing the relevant blocks? I definitely suspect an upstream issue, though I have no proof. |
so i found out i can trigger this behavior without going from none->gzip or none->snappy. just using gzip/snappy directly works too. i tried sniffing with wireshark but it's hard to inspect the tcp stream, it looks pretty garbled. probably due to the compression. |
Is #720 the explanation? |
Hey @eapache don't have time to run the test right now but it seems very likely! glad we're on to something! |
Yes, this is the same as #720. |
using the latest sarama i'm still seeing this when trying to use snappy:
i use config.Version = sarama.V0_10_0_0 btw. we manually manage offsets and use sarama.NewClient and sarama.NewConsumerFromClient |
It's possible my fix in #735 missed a case or something, but it worked in my simple tests so I'm not sure what might be going on. It would be helpful if you could put some additional logging in that flow and see where the issue is. |
Hi, I think if I interpret the kafka docs, i should be allowed to switch back and forth between none/gzip/snappy compression to the same topic/partition, right?
anyway when I try this, first i use no compression, than kill my producer, restart it with snappy or gzip compression, send data to the same topic/partition, i get this in the logs:
Sarama Version: latest git master
Kafka Version: 0.10
Go Version: 1.7rc1
any idea? thanks!
The text was updated successfully, but these errors were encountered: