Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SSL for v0.8.3 #154

Closed
joestein opened this issue Oct 8, 2014 · 9 comments
Closed

Support SSL for v0.8.3 #154

joestein opened this issue Oct 8, 2014 · 9 comments

Comments

@joestein
Copy link

joestein commented Oct 8, 2014

Kafka is adding SSL support => https://issues.apache.org/jira/browse/KAFKA-1477 and would be great to have this available in go libraries.

@eapache
Copy link
Contributor

eapache commented Oct 8, 2014

I don't see a super-obvious summary of how this will work, but I'm assuming this is something along the lines of "brokers will listen on an additional port for the existing kafka protocol wrapped in standard ssl"?

@eapache
Copy link
Contributor

eapache commented Oct 8, 2014

This looks like it will be fairly straightforward, we'll just need to use http://golang.org/pkg/crypto/tls/ and add a flag to switch between that and plain connections.

eapache added a commit that referenced this issue Oct 10, 2014
Possibly implements #154, if my assumptions about the implementation are
correct.
eapache added a commit that referenced this issue Dec 22, 2014
Possibly implements #154, if my assumptions about the implementation are
correct.
eapache added a commit that referenced this issue Feb 24, 2015
Possibly implements #154, if my assumptions about the implementation are
correct.
eapache added a commit that referenced this issue Mar 6, 2015
Possibly implements #154, if my assumptions about the implementation are
correct.
eapache added a commit that referenced this issue Mar 6, 2015
Possibly implements #154, if my assumptions about the implementation are
correct.
eapache added a commit that referenced this issue Mar 23, 2015
Possibly implements #154, if my assumptions about the implementation are
correct.
@uovobw
Copy link
Contributor

uovobw commented Jul 23, 2015

any news on this? i am planning on exposing a kafka cluster to the net securing it with stunnel and client side certificates. if there already is some code i can contribute to that...

@eapache
Copy link
Contributor

eapache commented Jul 23, 2015

Sarama's support is ready to go... we're waiting on upstream kafka to release this in the broker

@uovobw
Copy link
Contributor

uovobw commented Jul 23, 2015

i heard that is scheduled to happen in version 0.9, that might be a long way to come yet.
is there any chance that, with external ssl-termination as i wrote above, this could be pushed earlier?

@eapache
Copy link
Contributor

eapache commented Jul 23, 2015

#156 needs to be rebased and have any merge conflicts resolved, but it should be all you need.

@uovobw
Copy link
Contributor

uovobw commented Jul 23, 2015

awesome, i'll get around to it if i get the time. thanks

@uovobw
Copy link
Contributor

uovobw commented Jul 23, 2015

@eapache i have submitted a new pr #493 that rebases this change to master (branch support-ssl). tests pass, let me know how i can help

EDIT: a letter

eapache added a commit that referenced this issue Jul 24, 2015
Possibly implements #154, if my assumptions about the implementation are
correct.
eapache added a commit that referenced this issue Jul 28, 2015
Possibly implements #154, if my assumptions about the implementation are
correct.
@eapache eapache closed this as completed Aug 6, 2015
@eapache
Copy link
Contributor

eapache commented Aug 6, 2015

Implemented (for now) by #493

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants