Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcode integer sizes #427

Merged
merged 1 commit into from
Apr 16, 2015
Merged

Hardcode integer sizes #427

merged 1 commit into from
Apr 16, 2015

Commits on Apr 16, 2015

  1. Hardcode integer sizes

    My recent playing with benchmarks led me down the slippery slop into profiling,
    where I found this oddity. Calling `binary.Size()` actually involves reflection
    on the argument which is expensive (of course). There was really no reason not
    to hardcode these other than vague hand-waving towards portability (really).
    
    Saves us about 2.5% of profiled time in the producer benchmarks.
    eapache committed Apr 16, 2015
    Configuration menu
    Copy the full SHA
    37fcac5 View commit details
    Browse the repository at this point in the history