Refactor producer goroutines somewhat #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rename topicDispatcher to dispatcher - make a topicProducer struct to handle the old partitionDispatcher - make a partitionProducer struct to handle the old leaderDispatcher - move and rename methods for a much more readable structure Part 1 of #300.
| // (which sends the message to the broker). In cases where a message must be retried, it goes | ||
| // through retryHandler before being returned to the top of the flow. | ||
| /////////////////////////////////////////// | ||
|
|
There was a problem hiding this comment.
We should probably replace this with something else.
There was a problem hiding this comment.
Ya. Once this is merged I'll try and find time for "part 2" which will be a similar process for the aggregator and flusher. At that point this comment can come back, except "flows through the following structs, via each dispatch() method".
|
This looks fine to me. Like we were discussing above, the main thing I am looking for is a way to communicate how these objects should be used. Whether that would be with docs, or somehow using a code style I don't know. We can tackle this after step 2. |
|
It's going to be part of my talk at Golang UK if nothing else :) |
eapache
added a commit
that referenced
this pull request
Jul 10, 2015
Refactor producer goroutines somewhat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1 of #300.
There shouldn't be any functional changes. Thoughts @Shopify/kafka ?