Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CustomHasher #841

Merged
merged 3 commits into from
Mar 2, 2017
Merged

Fix CustomHasher #841

merged 3 commits into from
Mar 2, 2017

Commits on Feb 28, 2017

  1. Implement hasher as a callback function

    @kruftmeister
    kruftmeister committed Feb 28, 2017
    Configuration menu
    Copy the full SHA
    088e472 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2017

  1. Fix concurrency issue in hashedPartitioner 

    Passing an already instantiated hasher is a really bad idea. Instead pass a function returning the expected interface,
so the hasher is instantiated when needed, also assuring there's one hasher for each partitionDispatcher and thus avoid concurrency problems."
    @kruftmeister
    kruftmeister committed Mar 2, 2017
    Configuration menu
    Copy the full SHA
    f3b2363 View commit details
    Browse the repository at this point in the history

  2. Minor changes to reflect comments to PR 

    Remove type hasherFunc.
Adjust doc comments for the NewCustomHashPartitioner.
    @kruftmeister
    kruftmeister committed Mar 2, 2017
    Configuration menu
    Copy the full SHA
    8637e89 View commit details
    Browse the repository at this point in the history