Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove detectionContext instanceof DetectionContext context from the translation #165

Open
hugoqnc opened this issue Sep 27, 2024 · 0 comments
Open

Remove detectionContext instanceof DetectionContext context from the translation #165

hugoqnc opened this issue Sep 27, 2024 · 0 comments
Assignees
@n1ckl0sk0rtge

Comments

@hugoqnc
Copy link
Contributor

hugoqnc commented Sep 27, 2024

The translate functions should use a DetectionContext instead of an IDetectionContext.
Doing this should allow to remove the unnecessary check detectionContext instanceof DetectionContext context everywhere in the translation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@n1ckl0sk0rtge n1ckl0sk0rtge

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@n1ckl0sk0rtge @hugoqnc