Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use utf-16 to inz constant chars to be source ccsid independent on build #36

Merged
merged 1 commit into from
Jul 24, 2019
Merged

Use utf-16 to inz constant chars to be source ccsid independent on build #36

merged 1 commit into from
Jul 24, 2019

Conversation

jimoibm
Copy link
Contributor

@jimoibm jimoibm commented Apr 25, 2019

@kadler Here is the code changes for #32 .Please help take a look.

Signed-off-by: jimoibm <jimo@cn.ibm.com>
@jimoibm
Copy link
Contributor Author

jimoibm commented Apr 25, 2019

@kadler TGTCCSID is not supported in CRTRPGMOD. The latest committed build script has this error.

bash-4.4$ make
(system -q 'CHKOBJ QXMLSERV *LIB' || system -q 'CRTLIB QXMLSERV') && touch QXMLSERV.lib
system "CRTRPGMOD MODULE(QXMLSERV/xmlmain) SRCSTMF('src/xmlmain.rpgle') DBGVIEW(*SOURCE) REPLACE(*YES) TGTCCSID(37)" > xmlmain.log 2> xmlmain.msg && rm xmlmain.log xmlmain.msg || touch xmlmain.failed
test ! -e xmlmain.msg || cat xmlmain.msg
CPD0043: Keyword TGTCCSID not valid for this command.
CPF0006: Errors occurred in command.
test ! -e xmlmain.log || ./parse.sh xmlmain.log
if [ -e xmlmain.failed ]; then rm xmlmain.failed; exit 1; fi
make: *** [Makefile:97: xmlmain.module] Error 1

@jimoibm
Copy link
Contributor Author

jimoibm commented Apr 25, 2019

@kadler Thanks! But looks like the exportsrc change was committed. There are missing procedures like RUNASCII..

@kadler
Copy link
Member

kadler commented Apr 25, 2019

Yes, I realized that later afterward. We'll need to update it.

@jimoibm
Copy link
Contributor Author

jimoibm commented Jul 1, 2019

@kadler Is my code OK to move in? Thanks!

@kadler
Copy link
Member

kadler commented Jul 1, 2019

Sorry, I won't have time to review until next week.

@jimoibm
Copy link
Contributor Author

jimoibm commented Jul 2, 2019

Thanks @kadler ! I will create another request from ICC... want us to extend the CGI pwd length in 10 chars. Will also have that in the latest ptf if possible.

@jimoibm
Copy link
Contributor Author

jimoibm commented Jul 24, 2019

@kadler Is this change OK to be move in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants