Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sofc Keras Surrogates failing tests #1431

Closed
rundxdi opened this issue Jun 13, 2024 · 5 comments · Fixed by #1475
Closed

Sofc Keras Surrogates failing tests #1431

rundxdi opened this issue Jun 13, 2024 · 5 comments · Fixed by #1475
Assignees
Labels
Priority:High High Priority Issue or PR

Comments

@rundxdi
Copy link
Contributor

rundxdi commented Jun 13, 2024

Tests on sofc_keras_surrogate.py are failing due to an out-of-date Keras model that needs to be re-generated by someone who knows about the model. A deprecation warning indicating these failures has been added.

@rundxdi rundxdi added the Priority:High High Priority Issue or PR label Jun 13, 2024
@ksbeattie
Copy link
Member

Discovered in #1401

@ksbeattie
Copy link
Member

This will need to wait for #1401 to be merged before re-generating the model (and other keras related ones).

@lbianchi-lbl
Copy link
Contributor

This should be done independently of #1401 so that #1401 is not held up. A separate PR after #1401 is merged should be created once @AlexNoring recreates the model using the updated (post-#1401) supported version of Keras/Tensorflow.

@AlexNoring
Copy link
Contributor

The SOFC flowsheets in the examples repository no longer use the keras surrogates. I'd suggest we simply remove the files.

@ksbeattie
Copy link
Member

@bpaul4 will open a PR addressing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:High High Priority Issue or PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants