Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PriceTaker Model Checklist #1449

Open
8 tasks
adam-a-a opened this issue Jul 9, 2024 · 4 comments
Open
8 tasks

PriceTaker Model Checklist #1449

adam-a-a opened this issue Jul 9, 2024 · 4 comments
Assignees
Labels
DISPATCHES Priority:Normal Normal Priority Issue or PR WaterTAP

Comments

@adam-a-a
Copy link
Contributor

adam-a-a commented Jul 9, 2024

The PriceTaker class must still be merged into the main codebase. This class and associated workflow can be useful for projects related to DISPATCHES-type work. For example, modeling flexible desalination in WaterTAP is of interest, and we could make use of the Pricetaker class.

Here is a to-do list based on @andrewlee94 's suggested changes and @radhakrishnatg 's suggestions for enhancement.

**Finish PR #1358 **

Create new PR(s) for the following

  • Enable addition of startup, shutdown, ramping, etc. constraints when representative days (as opposed to full-year price signal) are used
  • Enable addition of cash flow/cost expressions when representative days are used
  • consider testing with IDAES process model (beyond simplified surrogate models that don't use typical IDAES unit models)
  • allow for different temporal resolution; cashflow calcs limited to hourly
@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label Jul 11, 2024
@ksbeattie
Copy link
Member

@adam-a-a, @MarcusHolly, @radhakrishnatg will you be opening PRs here in idaes-pse for this? If so, might one of you be able to join the dev call to discuss and track progress? If not any of you, then who?

@adam-a-a
Copy link
Contributor Author

@ksbeattie the initial plan is to help get #1358 merged first, and we broke down separate tasks (and assignees) for getting that done. At least one of us should be able to attend every now and then to give updates.

As for new PRs, we would open these here on idaes-PSE, only after merging said PR.

@MarcusHolly
Copy link
Contributor

@ksbeattie the initial plan is to help get #1358 merged first, and we broke down separate tasks (and assignees) for getting that done. At least one of us should be able to attend every now and then to give updates.

As for new PRs, we would open these here on idaes-PSE, only after merging said PR.

I just joined the call and gave a brief update, more or less saying what you've stated here. I can join the calls in the future.

@ksbeattie
Copy link
Member

Moving this to the Nov release board.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DISPATCHES Priority:Normal Normal Priority Issue or PR WaterTAP
Projects
None yet
Development

No branches or pull requests

4 participants