Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use el8 binaries when we encounter RHEL9 #1457

Closed
wants to merge 1 commit into from
Closed

Use el8 binaries when we encounter RHEL9 #1457

wants to merge 1 commit into from

Conversation

Robbybp
Copy link
Member

@Robbybp Robbybp commented Jul 23, 2024

Fixes #1456

Hopefully. I don't have RHEL9 or Rocky9, so I haven't tested.

Changes proposed in this PR:

  • Change el9, rhel9, and rocky9 to point to our el8 binaries

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.35%. Comparing base (80d37a8) to head (dd20dd3).
Report is 5 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1457      +/-   ##
==========================================
- Coverage   76.36%   76.35%   -0.01%     
==========================================
  Files         394      394              
  Lines       64953    64953              
  Branches    14404    14404              
==========================================
- Hits        49601    49598       -3     
- Misses      12793    12797       +4     
+ Partials     2559     2558       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lbianchi-lbl lbianchi-lbl mentioned this pull request Jul 23, 2024
Open
@ksbeattie ksbeattie added the Priority:High High Priority Issue or PR label Jul 25, 2024
@lbianchi-lbl
Copy link
Contributor

@eslickj just pinging you in case you can think of any reason why this change could have unexpected consequences; to me, without knowing the details, it looks reasonable.

ksbeattie
ksbeattie reviewed Aug 1, 2024
View reviewed changes
Copy link
Member

@ksbeattie ksbeattie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting for @mrmundt to run testing from this branch

@ksbeattie ksbeattie added Priority:Normal Normal Priority Issue or PR and removed Priority:High High Priority Issue or PR labels Aug 8, 2024
@mrmundt
Copy link
Contributor

mrmundt commented Aug 8, 2024

This PR is going to be superseded by IDAES/idaes-ext#274 <- completion of that will mean we have a RHEL9 binary anyway, so this temporary remapping will be irrelevant.

@ksbeattie
Copy link
Member

Closed in preference to IDAES/idaes-ext#274

@ksbeattie ksbeattie closed this Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksbeattie ksbeattie ksbeattie left review comments

@lbianchi-lbl lbianchi-lbl lbianchi-lbl approved these changes

@eslickj eslickj Awaiting requested review from eslickj

Assignees

@mrmundt mrmundt

Labels
Priority:Normal Normal Priority Issue or PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

idaes get-extensions: All unidentified Linux distributions default to Ubuntu?
5 participants
@Robbybp @codecov-commenter @lbianchi-lbl @mrmundt @ksbeattie