Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong units for material_holdup using mass basis #1461

Closed
adam-a-a opened this issue Jul 30, 2024 · 0 comments · Fixed by #1460
Closed

Wrong units for material_holdup using mass basis #1461

adam-a-a opened this issue Jul 30, 2024 · 0 comments · Fixed by #1460
Assignees
@adam-a-a
Labels
Priority:High High Priority Issue or PR WaterTAP

Comments

@adam-a-a
Copy link
Contributor

When trying to set up a dynamic unit model using ControlVolume0D on a mass basis, unit consistency issues will arise since the current implementation hard-codes units to mol for material_holdup. Instead, the units should be set based on the material flow basis set in the property model (mass or mole).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adam-a-a adam-a-a

Labels
Priority:High High Priority Issue or PR WaterTAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Repair erroneous units for material_holdup in CV0D when mass basis defined IDAES/idaes-pse
1 participant
@adam-a-a