Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update idaes-ext version from 3.4.0 #1470

Closed
lbianchi-lbl opened this issue Aug 15, 2024 · 2 comments · Fixed by #1473
Closed

Update idaes-ext version from 3.4.0 #1470

lbianchi-lbl opened this issue Aug 15, 2024 · 2 comments · Fixed by #1473
Assignees
Labels
Priority:Normal Normal Priority Issue or PR

Comments

@lbianchi-lbl
Copy link
Contributor

  • The topic of whether the idaes-ext version specified in this repository should be updated from the current 3.4.0 came up today during the dev call
  • @jsiirola brought up the point that we might want to use 3.4.2 since the binaries are the same as 3.4.0 (IIRC)
  • This issue is mostly for @Robbybp and @mrmundt to chime in and decide when the idaes-ext version should be updated (e.g. for the Aug 2024 release, or a later release, etc)
@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label Aug 15, 2024
@Robbybp
Copy link
Member

Robbybp commented Aug 15, 2024

I support updating to the 3.4.2 binaries for this release. I'd like to run the idaes-ext tests (IDAES test suite) with these binaries before doing so, but otherwise I'm all for bumping the version. Do you know what the proper order is for testing a new release? Update idaes-ext-3.4.2 to be the latest release (instead of pre-release), then bump the version here, then run the tests on idaes-ext (which just use idaes get-extensions). It seems like we should be able to run the idaes-ext tests off a pre-release (by passing a url argument to idaes get-extensions?), so I'll look into that. For now, I'm running the tests with 3.4.0 to establish a baseline (see https://github.com/IDAES/idaes-ext/actions).

@Robbybp
Copy link
Member

Robbybp commented Aug 16, 2024

Tests don't look any worse than those with 3.4.0, so I say we bump the version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:Normal Normal Priority Issue or PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants