Zeus - Fix remote control breaking Racks and resetting custom PTTs #1305
Conversation
Previously, PTT customization would be reset after using a remote controlled AI's radios.
mrschick
force-pushed
the
fix/zeus-rc-racks-ppts
branch
from
97caee7
to
4c54e78
Compare
There was a problem hiding this comment.
How does this work when controlling a UAV, as that is also remote control?
My fix works by limiting Rack initialization and PFH launch to only player units entering a vehicle, effectively preventing use of Racks by RCd AI entirely.
It's more of a workaround but it does prevent an issue, so I am fine with accepting this change, but we should add a note in documentation.
|
@BrettMayson Since you authored all of the Zeus compatibility, mind taking a look at this? |
I did not think of testing that. Unless it also changes
Maybe we can figure out an actual fix. Didn't look too much into it due to not seeing a use case in which a RCd AI should have to use Racks. |
Turns out |
Co-authored-by: jonpas <jonpas33@gmail.com>
|
Haven't looked too deep into it, but given the lack of apparent use-cases I don't think implementing Racks being accessible by RCd AI is worth the time. |
When merged this pull request will:
It was caused by the
sys_rack/fnc_rackPFH.sqfPFH being started when entering that AI and not terminated when exiting it, resulting in the PFH constantly disconnecting the player from his Racks. My fix works by limiting Rack initialization and PFH launch to only player units entering a vehicle, effectively preventing use of Racks by RCd AI entirely.A minor bug I encountered some time ago, happened because there was only a single
DVAR(ACRE_ASSIGNED_PTT_RADIOS)that stored custom PTT assignments, when controlling a unit and using its radiossys_core/fnc_handleMultiPttKeyPress.sqfwould check for the custom PTT radios to be present, not find them on the AI and reset the list. Now there are 2 DVARs to remember custom PTT assignments on the player and last controlled AI unit.