restore old is_different #932
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failing tests are apparently unrelated to these changes as they also fail on master. |
|
The failing tests seem to be related to mongo or mongomock (again...) I think it's better to add the check for the shape than to restore the old behavior, otherwise we get the issues back that we wanted to solve with this modification. |
|
We wanted to avoid the numpy 2.0 change but since that was apparently an unintended bug numpy/numpy#27271 , I see no reason to keep a fix that is not necessary. However, as discussed I am also fine with a proper implementation that properly checks whether something is not equal. |
|
closed in favor of #933 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #930 (comment)
New numpy releases fixed the
array_equalmethod.