Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: CMake build #344

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from
Open

WIP: CMake build #344

wants to merge 13 commits into from

Conversation

nolyn
Copy link
Contributor

@nolyn nolyn commented Apr 8, 2021

I added a cmake file which allows to build the project. I also updated the CI workflows to use it. Shouldn't merge it right away, since there are still some things to think about:

  • Do we replace the old build system (qt project files) or keep it?
  • Kept the old CI release uploads for now. New ones are added alongside
  • The unit test didn't work on the windows workflow, but I can not debug it since I don't have windows system.
  • Do we want to integrate any sanitizers? See http://www.stablecoder.ca/2018/02/01/analyzer-build-types.html. Could also add this later on.
  • Possibly more that I don't have on my mind right now.

@nolyn nolyn requested a review from ChristianFeldmann April 8, 2021 19:05
@nolyn
Copy link
Contributor Author

nolyn commented Apr 25, 2021

Setting the version/hash with cmake and git describe/rev-parse should now work

… to avoid name conflict with qmake build workflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant