Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few more questions about nmos_code.py #89

Open
eskiyerli opened this issue Apr 28, 2024 · 3 comments
Open

A few more questions about nmos_code.py #89

eskiyerli opened this issue Apr 28, 2024 · 3 comments
Labels
question Further information is requested

Comments

@eskiyerli
Copy link

eskiyerli commented Apr 28, 2024

  1. I don't understand why you would define epsilon twice:

     self.epsilon = techparams['epsilon1']
     Cell = self.__class__.__name__
     typ = 'N'
     hv = False
     
     epsilon = techparams['epsilon1']
    
  2. epsilon is defined as "epsilon1": 0.001, in json file. What is the purpose of this code:
    ng = math.floor(Numeric(ng)+epsilon)
    As far as I see, it has no effect.

@KrzysztofHerman KrzysztofHerman added the invalid This doesn't seem right label Apr 29, 2024
@eskiyerli
Copy link
Author

Why is it invalid?

@KrzysztofHerman
Copy link
Contributor

It is only a marker for our team to check validity.

@sergeiandreyev
Copy link
Contributor

sergeiandreyev commented May 17, 2024

@eskiyerli, I agree, there is long way to go to fine-tune and even clean-up the code..

@sergeiandreyev sergeiandreyev added question Further information is requested and removed invalid This doesn't seem right labels May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants