Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible discrepancy between Pres. API spec. and JSON-LD Context re. viewingDirection #2297

Closed
milvld opened this issue May 15, 2024 · 2 comments · Fixed by #2305
Closed

Comments

@milvld
Copy link

milvld commented May 15, 2024

While browsing the Presentation API specification and the accompanying JSON-LD Context, I've noticed that the specification states that the value of viewingDirection 'MUST be a String', whereas the Context views this as an @ container of @ set.

Is it possible that this is a contradiction? Since it results in the fact that the manifest outputted using this context, uses an array of strings for viewingDirection rather than a single string value.

@azaroth42 azaroth42 added this to the Presentation 3.0.1 milestone Jun 6, 2024
@azaroth42
Copy link
Member

Great catch, thank you! It shouldn't be @container:@set in the context

@azaroth42
Copy link
Member

Dawn and Rob note that this can be fixed at any time as context is not semantically versioned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants