Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mm39 endpoint is hard coded #2

Open
rbpatt2019 opened this issue Jan 13, 2022 · 1 comment
Open

mm39 endpoint is hard coded #2

rbpatt2019 opened this issue Jan 13, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@rbpatt2019
Copy link
Collaborator

Currently, the mm39 end point is hardcoded into the pipeline. We (should) be able to grep the desired end version out of the provided gtf link then get the proper endpoint from Liftover automatically.

This will require restructuring the config, as well as expanding some rules in common.py to automatically handle this.

@rbpatt2019 rbpatt2019 added the bug Something isn't working label Jan 13, 2022
@rbpatt2019 rbpatt2019 self-assigned this Jan 13, 2022
@rbpatt2019
Copy link
Collaborator Author

Some further inspections shows that this isn't entirely true. The names of the rules certainly make it seem this way, but, as all URLs are provided by the user, the pipeline will handle any conversion as long as all the endpoints are consistent. That is, if you want to lift onto XX, then you download an XX GTF, FASTA, and the mm10 to XX liftover file.

I'm going to leave this open for future development. I think we could handle this better. Most of the default sources have very well structured URLs. Maybe we could simply ask for the species and build, then construct the paths ourselves.

@rbpatt2019 rbpatt2019 added enhancement New feature or request and removed bug Something isn't working labels Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant