You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Set default component settings in adapters and global settings in PipelineModule by defining an abstract method get_default_settings() and overriding this in the individual adapters.
Document which Tags are used by each adapter and what the sensible defaults are
adjust the examples so that they don't need to specify all settings anymore
test if specified settings override the default settings
In PR #358 I've now implemented a way to set default component settings for the adapters and default global settings. I think before proceeding further with the documentation, examples and tests it would make sense to have a meeting where we go through this list and check if all default values are sensible and if no default parameter was forgotten.
Furthermore three questions came up:
Should processing components also have default settings?
Would it make sense to treat all settings as a read-only configuration? Then we would have to find a new solution for the wavelength and simpa_output_path in the simulate method which are currently stored in the global settings during simulation. Passing them as an additional argument to the run method of the pipeline elements would be one option.
Would it make sense to have a list of required (component) settings for each adapter which can be checked in the beginning of each adapter and a warning or error can be logged if something is missing. Then the user would have a better overview which of these required settings are already set by default and which they have to set manually. This should of course also be included into the documentation of each adapter.
Define abstract method in SimulatioModule class
The text was updated successfully, but these errors were encountered: