Fixed detector positioning in msot acuity echo #149
Conversation
|
Looks sensible. Feel free to merge this if you are confident the device is now correctly represented! |
…model_based_volume_creator method
|
@jgroehl I ran all the tests and everything that should work also worked, however, in the examples I realized that there was another bug with the positioning. I corrected that with a new commit |
|
Great that the checks are now running automatically!! many thanks for setting this up @kdreher !! |
| @@ -190,7 +188,7 @@ def update_settings_for_use_of_model_based_volume_creator(self, global_settings) | |||
| self.set_detection_geometry(detection_geometry) | |||
| for illumination_geom in self.illumination_geometries: | |||
| illumination_geom.device_position_mm = np.add(illumination_geom.device_position_mm, | |||
| np.array([0, 0, probe_size_mm])) | |||
| np.array([width_shift_for_structures_mm, 0, probe_size_mm])) | |||
There was a problem hiding this comment.
I do not understand where this is coming from exactly.. Is it for "sliding" a probe along the x-axis to potentially simulate multiple areas of the same tissue model?
There was a problem hiding this comment.
No this comes from the check if the volume is not wide enough. Then the volume is enlarged on both sides and the structures are shifted accordingly so that they are still in the middle of the volume. Then, the device position also needs to be shifted by the same width. The device itself and the detection geometry were already shifted by that width but not the illumination
Fix for detector geometry positioning. When the
device_position_mmof theMSOTAcuityEchois already defined at the outer side of the membrane, the center of the detector geometry is onlyself.focus_in_field_of_view_mm(8mm) further away from the membrane