T77 off by one error #174
Merged
T77 off by one error #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdreher
approved these changes
Sep 23, 2022
Comment on lines
+79
to
+80
| else: | ||
| det_elements = 0 |
There was a problem hiding this comment.
We should catch the case where a user defines 0 detector elements and throw an Error instead of giving it a detector position
There was a problem hiding this comment.
I agree, in general we should catch the case where number_detector_elements <= 0 as this doesn't make sense. At the moment the else case is only required if number_detector_elements == 1 to set the one detector element into central position.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #77 by adding a 0.5 pixel offset to the sensor positions in x direction to make them and the delays to their position symmetric (left most and right most pixels of a centred volume should have the same delay to the detector elements). In y direction the correction in the acoustic simulation was removed which solves the off-by-one error. Please check if this correction is still necessary (in my test case it was not necessary), then we might have to find an other solution.
I've also slightly changed the image dimension computation to reduce rounding issues and mitigate large offset errors by distributing them equally. I've written tests for some cases of this function but we could certainly add even more test cases.