Fix ignored acoustical_simulation_3d #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomTomRixRix
previously requested changes
Oct 6, 2023
There was a problem hiding this comment.
I would prefer it to have just one boolean variable to switch between 2D and 3D. Now we have acoustic_simulation_3d and simulate_2d. While this should technically work, it makes it very complicated to understand, especially with negated conditional statements.
I would do a one liner where you check for the tag and directly access it:
if Tags.ACOUSTIC_SIMULATION_3D in settings and not settings[Tags.ACOUSTIC_SIMULATION_3D]:
# 2D case
else:
#3D case
|
And here also merge into |
jgroehl
requested changes
Aug 13, 2024
| @@ -99,16 +99,15 @@ def forward_model(self, detection_geometry: DetectionGeometryBase) -> np.ndarray | |||
|
|
|||
| detectors_are_aligned_along_x_axis = field_of_view_extent[2] == 0 and field_of_view_extent[3] == 0 | |||
| detectors_are_aligned_along_y_axis = field_of_view_extent[0] == 0 and field_of_view_extent[1] == 0 | |||
| if detectors_are_aligned_along_x_axis or detectors_are_aligned_along_y_axis: | |||
| axes = (0, 1) | |||
| if not self.component_settings[Tags.ACOUSTIC_SIMULATION_3D] and \ | |||
There was a problem hiding this comment.
I'd change this to the same pattern as lines 158-159 to avoid a key error.
jgroehl
approved these changes
Aug 13, 2024
kdreher
dismissed
TomTomRixRix’s stale review
We added the changes you requested :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check the following before creating the pull request (PR):
Provide issue / feature request fixed by this PR
Fixes #223
For now added a standard check if the Tag is in the settings, if not use False as default. In the future it would be nice to support .get() in Settings.