making Post Prominence tax items created via wp-admin visible on post add/edit screens #1255
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an update of #1252, but applied against the master branch as a hotfix
Fixes issue identified in #956
Prominence Terms added via
/wp-admin/edit-tags.php?taxonomy=prominence
are not displayed in the add/edit post screens.This appears to be caused by the for loop that creates $termList in https://github.com/INN/Largo/blob/master/inc/post-metaboxes.php#L314
$largoProminenceTerms
and by extension,$slugs
only pull the default options set in the theme at https://github.com/INN/Largo/blob/master/inc/taxonomies.php#L90, so the for loop is only adding items to the display which exist in the default theme set.I'm not sure if this loop was intended for something else, but removing it entirely and renaming
$terms
to$termList
fixes the issue.