Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

largo_post_social_links should respect get_option('blog_charset') #1283

Closed
benlk opened this issue Aug 31, 2016 · 0 comments
Closed

largo_post_social_links should respect get_option('blog_charset') #1283

benlk opened this issue Aug 31, 2016 · 0 comments

Comments

@benlk
Copy link
Collaborator

benlk commented Aug 31, 2016

https://github.com/INN/Largo/blob/d94cf0c39643c701fb443253334dc78079f0e8e8/inc/post-tags.php#L247:

            $output .= sprintf(
                $twitter_share,
                // Yes, rawurlencode. Otherwise, the link will break. Use html_entity_decode to handle wordpress saving smart quotes as Ӓ entities.
                rawurlencode( html_entity_decode( get_the_title(), ENT_QUOTES, "UTF-8" ) ),
                rawurlencode( get_permalink() ),
                $via,
                __( 'Tweet', 'largo' )
            );

But we use proper support in https://github.com/INN/Largo/blob/a5a0b7fdaedcfe261023be7e6f642956d51e58b4/inc/widgets/largo-inn-rss.php#L80 :

            $desc = str_replace( array("\n", "\r"), ' ', esc_attr( strip_tags( @html_entity_decode( $item->get_description(), ENT_QUOTES, get_option('blog_charset') ) ) ) );
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants