Largo declares support for title-tag but doesn't implement it #1470
Labels
priority: normal
Must be completed before release of this version of plugin.
status: needs review
type: bug
Milestone
https://github.com/INN/largo/blob/v0.5.5.3/functions.php#L424
in the function largo_setup, we declare theme support for
'title-tag'
.'title-tag'
means that the theme doesn't have any<title>
tags in it, and the ones that are there are wrapped as backwards-compatibility functions for WordPress versions before 4.1. See the Codex article for what the backwards compatibility function looks like.The reason this is a problem is because we have both
add_theme_support( 'title-tag' );
and<title
tags in theheader.php
file. We should have either one or the other.https://github.com/INN/largo/blob/v0.5.5.3/header.php#L24-L25
The theme-output
title
tag pairs with the WordPress-outputtitle
tag to result in all Largo sites outputting two different title tags.Most people notice this when they activate an SEO plugin like Yoast, which, seeing the
title-tag
support, modifies the WordPress-output title tag, but because that comes after the Largo-output title tag, it doesn't affect the actual parsed title rendered by browsers or search engines.There's two possible fixes:
add_theme_support( 'title-tag' );
: not recommended; this is required in WordPress since 2015: https://make.wordpress.org/themes/2015/08/25/title-tag-support-now-required/Until a fix for this ships in Largo, we can patch child themes by copying Largo's header.php and removing the relevant lines.
The text was updated successfully, but these errors were encountered: