Clicking on the image on an already-open slideshow breaks #1695's fix for images having different widths after the modal is closed #1700
Labels
category: images
Issues relating to images
Estimate: < 6 Hours
priority: normal
Must be completed before release of this version of plugin.
type: bug
Milestone
Given a single image in an image block that is aligned left or right, take the following steps to reproduce this bug:
addCloseX
is called again, adding a duplicateX
in the modal (which is invisible to the user because it's stacked atop the current X, using the same CSS rules for positioning)closeSingle
https://github.com/INN/largo/blob/e2ac830239452658c285860b330d521c6a0f300e/lib/navis-slideshows/js/navis-slideshows.js#L274-L276closeSingle
when the image is closed: https://github.com/INN/largo/blob/e2ac830239452658c285860b330d521c6a0f300e/lib/navis-slideshows/js/navis-slideshows.js#L177So the questions I have are:
!important
?img
to check that it doesn't have a.navis-before
class as its sibling, which would mean that the dialog has been opened? We'd want to apply that here:https://github.com/INN/largo/blob/e2ac830239452658c285860b330d521c6a0f300e/lib/navis-slideshows/js/navis-slideshows.js#L254-L255
The text was updated successfully, but these errors were encountered: