Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Open Graph tags on singular post types, and minor search improvements #1604

Merged
merged 8 commits into from
Dec 17, 2018

Conversation

benlk
Copy link
Collaborator

@benlk benlk commented Dec 17, 2018

Changes

  • Fixes issue where post excerpt and featured media were not being used for open graph tags on post types that are is_singular() but not is_single(). Pull request # for issue #1602.
  • Removes duplicate site title in opengraph tags for non-archive, non-is_front_page(), non-is_singular() URLs. Pull request # for issue #1602.
  • Removes search form from global nav bar when on the search page, so that there's only one search form. Pull request # .
  • Cleans up the search page when no query has been entered. Pull request # for issue #1603.

Screenshots

GCSE before:

screen shot 2018-12-17 at 1 39 31 pm

GCSE after:

screen shot 2018-12-17 at 1 57 33 pm

Why

@benlk benlk added this to the 0.6.2 milestone Dec 17, 2018
@benlk benlk added type: bug priority: normal Must be completed before release of this version of plugin. labels Dec 17, 2018
@benlk benlk merged commit 0614420 into 0.5-dev Dec 17, 2018
benlk added a commit to INN/umbrella-inndev that referenced this pull request Dec 17, 2018
@benlk benlk deleted the 1602-opengraph-cleanup branch July 18, 2019 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: normal Must be completed before release of this version of plugin. type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant