Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pullquote specific styles #1746

Merged

Conversation

joshdarby
Copy link
Collaborator

Changes

This pull request makes the following changes:

  • Updated the styling for pull quotes so they look different than normal block quotes.

Before:
Screen Shot 2019-07-15 at 9 06 13 AM

After:
Left:
Screen Shot 2019-07-12 at 4 29 23 PM

Right:
Screen Shot 2019-07-12 at 4 28 05 PM

Full-width:
Screen Shot 2019-07-12 at 4 30 32 PM

Wide:
Screen Shot 2019-07-12 at 4 30 08 PM

Normal:
Screen Shot 2019-07-12 at 4 31 45 PM

Why

For #1699.

Testing/Questions

Features that this PR affects:

  • Pull quote blocks.

Questions that need to be answered before merging:

  • Should we update any other styles for pull/block quotes?

Steps to test this PR:

  1. Add a pull quote block to a post
  2. Make sure it looks ok left aligned, right aligned, center aligned, and normal, wide, and full widths.

@joshdarby joshdarby added type: bug priority: normal Must be completed before release of this version of plugin. type: feature request category: styles affects lots of styles, requiring visual testing category: gutenberg Relating to general Gutenberg compatibility Estimate: < 6 Hours labels Jul 15, 2019
@joshdarby joshdarby added this to the 0.6.4 milestone Jul 15, 2019
@joshdarby joshdarby requested a review from benlk July 15, 2019 13:08
@joshdarby joshdarby self-assigned this Jul 15, 2019
@benlk benlk modified the milestone: 0.6.4 Jul 15, 2019
@benlk
Copy link
Collaborator

benlk commented Jul 16, 2019

Previous work in this area: #1687

Josh Darby and others added 4 commits July 16, 2019 11:21
…te styles, make some changes for uniformity, make it easier to style the pull quotes via inherit-based styles for paragraphs and citation.
… github.com:INN/largo into 1699-revisions-to-block-quote-and-pull-quote-styles
@benlk
Copy link
Collaborator

benlk commented Jul 16, 2019

Those most-recent commits:

  • Replace separate pullquote styles in 9749576 with adding the new .wp-block-pullquote class to the existing pullquote styles, similar to how https://github.com/INN/largo/pull/1687/files?file-filters%5B%5D=.less used the existing blockquote styles
  • Moves all the pullquote styles shared between Classic and Block Editors from posts-and-pages.less to typography.less, where other blockquote styles live. Block-specific pullquote and blockquote styles remain in blocks.less.

@benlk
Copy link
Collaborator

benlk commented Jul 16, 2019

An editor-specific style to override: the border-top and border-bottom on wp-block-pullquote.

Screen Shot 2019-07-16 at 16 09 01

@benlk
Copy link
Collaborator

benlk commented Jul 16, 2019

I will note that #1748 was already broken in Largo; be30571 just hides the borders in the editor.

@joshdarby do you think we should fix #1748 in this Largo release or in a later one? I wouldn't do it in this PR.

@benlk
Copy link
Collaborator

benlk commented Jul 16, 2019

These changes are ready for review by someone not-me.

@joshdarby
Copy link
Collaborator Author

@joshdarby do you think we should fix #1748 in this Largo release or in a later one? I wouldn't do it in this PR.

@benlk I'd prefer to get it done in this release since it is technically a bug, but since it was already broken... Has anyone complained specifically about not being able to specifically choose the color of the border? Worst comes to worst it can be edited by css by whoever wants to change it.

@joshdarby
Copy link
Collaborator Author

@benlk This still works as expected. Are you good with me merging it?

@benlk
Copy link
Collaborator

benlk commented Jul 16, 2019

I haven't heard any user complaints about #1748 yet. Let's aim for putting that in the next release, and merging this.

@joshdarby joshdarby merged commit b023482 into 0.5-dev Jul 16, 2019
@benlk benlk deleted the 1699-revisions-to-block-quote-and-pull-quote-styles branch July 18, 2019 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: gutenberg Relating to general Gutenberg compatibility category: styles affects lots of styles, requiring visual testing Estimate: < 6 Hours priority: normal Must be completed before release of this version of plugin. type: bug type: feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants