-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pullquote specific styles #1746
Add pullquote specific styles #1746
Conversation
Previous work in this area: #1687 |
…te styles, make some changes for uniformity, make it easier to style the pull quotes via inherit-based styles for paragraphs and citation.
… github.com:INN/largo into 1699-revisions-to-block-quote-and-pull-quote-styles
Those most-recent commits:
|
I will note that #1748 was already broken in Largo; be30571 just hides the borders in the editor. @joshdarby do you think we should fix #1748 in this Largo release or in a later one? I wouldn't do it in this PR. |
These changes are ready for review by someone not-me. |
@benlk I'd prefer to get it done in this release since it is technically a bug, but since it was already broken... Has anyone complained specifically about not being able to specifically choose the color of the border? Worst comes to worst it can be edited by css by whoever wants to change it. |
@benlk This still works as expected. Are you good with me merging it? |
I haven't heard any user complaints about #1748 yet. Let's aim for putting that in the next release, and merging this. |
Changes
This pull request makes the following changes:
Before:
![Screen Shot 2019-07-15 at 9 06 13 AM](https://user-images.githubusercontent.com/18353636/61218359-dd2ad380-a6df-11e9-910b-966361b935b4.png)
After:
![Screen Shot 2019-07-12 at 4 29 23 PM](https://user-images.githubusercontent.com/18353636/61156880-8eecb900-a4c2-11e9-83cd-d3eb54b62c50.png)
Left:
Right:
![Screen Shot 2019-07-12 at 4 28 05 PM](https://user-images.githubusercontent.com/18353636/61156881-8eecb900-a4c2-11e9-88df-400d7c11f7ae.png)
Full-width:
![Screen Shot 2019-07-12 at 4 30 32 PM](https://user-images.githubusercontent.com/18353636/61156878-8eecb900-a4c2-11e9-8f76-166fd44f4091.png)
Wide:
![Screen Shot 2019-07-12 at 4 30 08 PM](https://user-images.githubusercontent.com/18353636/61156879-8eecb900-a4c2-11e9-8694-1739863d72af.png)
Normal:
![Screen Shot 2019-07-12 at 4 31 45 PM](https://user-images.githubusercontent.com/18353636/61156877-8eecb900-a4c2-11e9-87c9-72b9e0aa7e6d.png)
Why
For #1699.
Testing/Questions
Features that this PR affects:
Questions that need to be answered before merging:
Steps to test this PR: