Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load updated custom CAFE metadata block (displayname changed from "Metadata About Data Location" to "Metadata About Geospatial Files") to demo and prod #244

Closed
jggautier opened this issue Feb 7, 2024 · 15 comments
Labels
NIH CAFE Issues associated with the NIH CAFE project Size: 3 A percentage of a sprint.

Comments

@jggautier
Copy link
Collaborator

jggautier commented Feb 7, 2024

Our contact for the CAFE collection let us know that depositors found the name of the custom metadata block, "Metadata About Data Location", confusing, taking it to mean "metadata about where the data are stored," when it should be metadata about where the data was collected or what the data is about.

He asked us to change the name of the metadata block, that is, the "displayName" entered in the metadata block's TSV file, to Metadata About Geospatial Files.

So in place of "Metadata About Data Location" in this panel on the dataset page:
Screenshot 2024-02-21 at 12 46 20 PM

It would be "Metadata About Geospatial Files".

@jggautier jggautier changed the title Rename custom "Metadata About Data Location" metadata block to "Metadata About Geospatial Files" Change displayname of custom "Metadata About Data Location" metadata block to "Metadata About Geospatial Files" Feb 7, 2024
@pdurbin
Copy link
Member

pdurbin commented Feb 7, 2024

@jggautier are you working on this? If not, I think @cmbz would agree that this could be a good issue for @Saixel.

I'm going to go ahead and give it a size of 3.

@pdurbin pdurbin added the Size: 3 A percentage of a sprint. label Feb 7, 2024
@jggautier
Copy link
Collaborator Author

I'm working on it but I wouldn't be able to make the change, which I think involves admin-level API calls. Coordinating with @Saixel sounds great to me!

@pdurbin
Copy link
Member

pdurbin commented Feb 7, 2024

@jggautier sounds good. Please request a review from @Saixel after you make a pull request so he can see the change.

He won't have access to prod though. So getting it into prod should go through the normal process.

@cmbz
Copy link
Collaborator

cmbz commented Feb 7, 2024

2024/02/07
Thanks. I've added this issue to the backlog Sprint Ready and the main CAFE tracking issue, too: IQSS/dataverse-pm#161

@cmbz cmbz moved this to SPRINT READY in IQSS Dataverse Project Feb 7, 2024
@jggautier
Copy link
Collaborator Author

jggautier commented Feb 8, 2024

Hmm, I haven't used pull requests in this repo. In the customCAFEDataLocation.tsv and customCAFEDataLocation.properties files I changed the displayName of the metadata block to "Metadata About Geospatial Files".

@Saixel, could you review the history of those changes?

@pdurbin
Copy link
Member

pdurbin commented Feb 9, 2024

@Saixel please read through the following: https://guides.dataverse.org/en/6.1/admin/metadatacustomization.html#loading-tsv-files-into-a-dataverse-installation

Then, please load the older version of the tsv to observe the old display name.

Then, please load the newer version to make sure it changed.

This is all new to you, so please reach out in Slack with questions! Thanks!

@cmbz cmbz added the NIH CAFE Issues associated with the NIH CAFE project label Feb 9, 2024
@pdurbin pdurbin moved this from SPRINT READY to This Sprint 🏃‍♀️ 🏃 in IQSS Dataverse Project Feb 14, 2024
@Saixel Saixel self-assigned this Feb 14, 2024
@Saixel Saixel moved this from This Sprint 🏃‍♀️ 🏃 to In Progress 💻 in IQSS Dataverse Project Feb 14, 2024
@Saixel
Copy link

Saixel commented Feb 15, 2024

I've followed the discussed steps and conducted the necessary tests. I created the customCAFEDataLocation.tsv and customCAFEDataLocation.tsv.properties files based on @jggautier's modifications. I've tested the functionality as required, executing both the old version of the TSV file and then the new one to ensure that the name updates without any issues @pdurbin

@Saixel Saixel moved this from In Progress 💻 to Ready for QA ⏩ in IQSS Dataverse Project Feb 15, 2024
@Saixel Saixel removed their assignment Feb 15, 2024
@scolapasta
Copy link

OK, after reviewing with @jggautier and @Saixel, seems like the remaining step is to load these into demo and prod. So I'm going to retitle this for that remaining task, and move back to This Sprint.

Let's do demo firs,t have @jggautier or @Saixel check to make sure it looks correct, then load into prod.

@scolapasta scolapasta changed the title Change displayname of custom "Metadata About Data Location" metadata block to "Metadata About Geospatial Files" Load updated custom CAFE metadata block (displayname changed from "Metadata About Data Location" to "Metadata About Geospatial Files") to demo and prod Feb 21, 2024
@scolapasta scolapasta moved this from Ready for QA ⏩ to This Sprint 🏃‍♀️ 🏃 in IQSS Dataverse Project Feb 21, 2024
@landreev landreev moved this from This Sprint 🏃‍♀️ 🏃 to In Progress 💻 in IQSS Dataverse Project Mar 27, 2024
@landreev landreev self-assigned this Mar 27, 2024
@landreev
Copy link
Collaborator

Updated in prod.
Just want to double-check before installing the blocks on demo - do we actually need them there? The CAFE blocks are not installed on demo as of now.

@jggautier
Copy link
Collaborator Author

I think the idea was to put it on Demo Dataverse first so that @Saixel or I could make sure the change is what we expect. And if it is, then someone could load it into Harvard Dataverse.

I just checked and the change on Harvard Dataverse is what I expected, so I don't think it needs to be added to Demo Dataverse. Maybe that first step wasn't needed at all since it's a small change; not much context needed to make sure the change happened the way we expected and maybe it's easy to reverse if something went wrong?

@landreev
Copy link
Collaborator

Oh, sorry, I didn't get that. Yeah, since it was just a label, probably ok to skip the testing stage.

Going forward, when a block is ready to be installed (in prod. or demo), feel free to just ping me on slack (or Steven if I'm not around). It really doesn't take any time at all.

@landreev
Copy link
Collaborator

OK to close this?

@jggautier
Copy link
Collaborator Author

Hmm, I'd say wait to hear from @Saixel. I think he's more aware of CAFE project-related things 👍

@landreev landreev removed their assignment Apr 8, 2024
@landreev
Copy link
Collaborator

landreev commented Apr 8, 2024

@jggautier ok if I put your name on this, so that you could close it once they confirm (or give it back to me if there are problems)?

@Saixel
Copy link

Saixel commented Apr 8, 2024

Everything okay, we can close this!

@cmbz cmbz moved this from In Progress 💻 to Done 🧹 in IQSS Dataverse Project Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NIH CAFE Issues associated with the NIH CAFE project Size: 3 A percentage of a sprint.
Projects
None yet
Development

No branches or pull requests

6 participants