Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

guestbook problems post-merge #10009

Closed
qqmyers opened this issue Oct 13, 2023 · 0 comments · Fixed by #10010
Closed

guestbook problems post-merge #10009

qqmyers opened this issue Oct 13, 2023 · 0 comments · Fixed by #10010

Comments

@qqmyers
Copy link
Member

qqmyers commented Oct 13, 2023

The fix in #9892 worked, but the guestbook-at-request PR #9599, which was created before #9892 was merged, moved the logic that was in file-download-popup-fragment.xhtml (including the #9825 issue) to the new guestbook-terms-popup-fragment.xhtml. The same fix now needs to be applied there instead. PR to follow.
@qqmyers qqmyers mentioned this issue Oct 13, 2023
Merged
@pdurbin pdurbin changed the title IT LIVES! #9825 guestbook problems post-merge Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

guestbook problems post-merge, refix 9825 QualitativeDataRepository/dataverse
1 participant
@qqmyers