Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guestbook email field does not check email validity #10661

Closed
DS-INRAE opened this issue Jul 1, 2024 · 3 comments · Fixed by #11022
Closed

Guestbook email field does not check email validity #10661

DS-INRAE opened this issue Jul 1, 2024 · 3 comments · Fixed by #11022
Labels
Size: 10 A percentage of a sprint. 7 hours. Type: Bug a defect
Milestone

Comments

@DS-INRAE
Copy link
Member

DS-INRAE commented Jul 1, 2024

What steps does it take to reproduce the issue?

  • Set a guestbook on a dataset
  • Attempt downloading files from the dataset
  • Enter a value in the email field of the guestbook which isn't a correct email
  • Voilà !

When does this issue occur?
With any guestbook

Which page(s) does it occurs on?
Guestbook (therefore dataset page and preview tab of files page)

What happens?
Email are not checked

To whom does it occur (all users, curators, superusers)?
File downloaders/explorers

What did you expect to happen?
Verify that the email address inputed is actually an email address

Which version of Dataverse are you using?
v5.14 (also seen on Demo Dataverse running v6.2)

Any related open or closed issues to this bug report?
Functionally unrelated but on guestbook checks :

Screenshots:

Screencast.from.2024-07-01.14-17-20.mp4
@DS-INRAE DS-INRAE added the Type: Bug a defect label Jul 1, 2024
@qqmyers
Copy link
Member

qqmyers commented Jul 1, 2024

related to #10625

@DS-INRAE
Copy link
Member Author

DS-INRAE commented Jul 9, 2024

Related to the discussion on zulip on validators for guestbook, as that would impact the API part for these fields : https://dataverse.zulipchat.com/#narrow/stream/379673-dev/topic/metadata.20validators.20per.20field/near/449952746

@DS-INRAE DS-INRAE moved this to ⚠️ Needed/Important in Recherche Data Gouv Jul 10, 2024
@sbarbosadataverse sbarbosadataverse added the Size: 10 A percentage of a sprint. 7 hours. label Jul 24, 2024
@cmbz cmbz moved this to SPRINT READY in IQSS Dataverse Project Aug 19, 2024
@cmbz
Copy link

cmbz commented Aug 19, 2024

2024/08/19

  • This could also impact frontend (we would want validation in UI as well as backend)

@stevenwinship stevenwinship self-assigned this Nov 14, 2024
@stevenwinship stevenwinship moved this from SPRINT READY to In Progress 💻 in IQSS Dataverse Project Nov 14, 2024
@stevenwinship stevenwinship removed their assignment Nov 15, 2024
@github-project-automation github-project-automation bot moved this from ⚠️ Needed/Important to Done in Recherche Data Gouv Nov 19, 2024
@pdurbin pdurbin added this to the 6.5 milestone Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: 10 A percentage of a sprint. 7 hours. Type: Bug a defect
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

6 participants