IQSS/11228 Summary Fields fixes #11229
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: This PR fixes the problem seen in #11228 where specify fields that don't have any values also removes the license display. It also supports having spaces in the :CustomDatasetSummaryFields setting comma-separated list of fields. It doesn't enforce any minimum set of fields, but the docs note that the default fields will disappear if you don't add them to your custom setting.
Which issue(s) this PR closes:
Special notes for your reviewer: Looks like the License got added into a table that was only rendered if there were values to show. It also looks like there was some hardcoding to check that the default fields had some value. Since we do want the license to display and the rest of the table doesn't cause problems if empty, I've just removed the jsf:rendered attribute.
Suggestions on how to test this: per the issue.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: added
Additional documentation: