Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataverse Theme - File upload for Logo Image does not have a file size limit if a logo already exists #3680

Closed
mheppler opened this issue Mar 8, 2017 · 2 comments
Labels
Component: JSF Involves modifying JSF (Jakarta Server Faces) code, which is being replaced with React. Feature: Dataverse General Info Edit dataverse > "General Information" > Name, Alias, Email, Metadata Fields, et al... Type: Bug a defect User Role: Depositor Creates datasets, uploads data, etc. UX & UI: New React UI Needs enough design work that it should probably go in the new React UI, not JSF

Comments

@mheppler
Copy link
Contributor

mheppler commented Mar 8, 2017

When working on making the dataset thumbnail #3559 consistent with the dataverse theme functionality, I discovered that there is render on the page that shows you one of two file upload widgets. There is an inconsistency between the validation on these two fileUpload widgets. One has the sizeLimit attribute and one doesn't. That means if a dataverse theme already has a file uploaded as the logo, and you try to upload a new logo, that file does not have any file size validation applied to it. I was able to upload a 1.3 MB image, when the stated limited is 500 KB.

@mheppler mheppler added Feature: Dataverse General Info Edit dataverse > "General Information" > Name, Alias, Email, Metadata Fields, et al... Type: Bug a defect labels Mar 8, 2017
@jggautier
Copy link
Contributor

jggautier commented May 13, 2021

Ran into this issue when fixing a logo display for a Dataverse collection in Harvard Dataverse Repository (https://dataverse.harvard.edu/dataverse/digistruct). The admins managed to upload a 2.2MB size PNG. This caused the image to be broken on the search page:

Screen Shot 2021-05-13 at 11 22 50 AM

I resized the image and re-uploaded it, but the image was still broken on the search page (even after several hard page refreshes, clearing my browser cache, and trying Chrome, Firefox and Safari (on MacOS)). I had to rename the resized image and re-upload - now the image shows on the search results page:

Screen Shot 2021-05-13 at 11 26 51 AM

@pdurbin pdurbin added User Role: Depositor Creates datasets, uploads data, etc. Component: JSF Involves modifying JSF (Jakarta Server Faces) code, which is being replaced with React. UX & UI: New React UI Needs enough design work that it should probably go in the new React UI, not JSF labels Oct 8, 2023
@cmbz
Copy link

cmbz commented Aug 20, 2024

To focus on the most important features and bugs, we are closing issues created before 2020 (version 5.0) that are not new feature requests with the label 'Type: Feature'.

If you created this issue and you feel the team should revisit this decision, please reopen the issue and leave a comment.

@cmbz cmbz closed this as completed Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: JSF Involves modifying JSF (Jakarta Server Faces) code, which is being replaced with React. Feature: Dataverse General Info Edit dataverse > "General Information" > Name, Alias, Email, Metadata Fields, et al... Type: Bug a defect User Role: Depositor Creates datasets, uploads data, etc. UX & UI: New React UI Needs enough design work that it should probably go in the new React UI, not JSF
Projects
None yet
Development

No branches or pull requests

4 participants