Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modifyRegistrationMetadata api and UpdateDvObjectPIDMetadataCommand will create filePIDs even if they are not in use #5552

Closed
qqmyers opened this issue Feb 14, 2019 · 0 comments
Assignees

Comments

@qqmyers
Copy link
Member

qqmyers commented Feb 14, 2019

The UpdateDvObjectPIDMetadataCommand, used by the /datasets/{id}/modifyRegistrationMetadata and /dataset/{id}/modifyRegistrationPIDMetadataAll api calls (and my implementation for #4760) doesn't check the file PID setting, so it will create one when it shouldn't (ignoring changes for #5505 which could flag/fail if the file doesn't currently have a PID). Further, if it should (the filePID flag allows), there would still be an issue if the files have no PID and PIDs are now allowed and the protocol/authority/filePID naming scheme (e.g. dependent) would cause an issue. Creating a PR that adds this check, mirroring the code in FinalizeDatasetPublicationCommand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants