Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On the Dataset Page, Filter Tags and File Types containing Spaces #5972

Closed
djbrooke opened this issue Jun 26, 2019 · 7 comments · Fixed by #5973
Closed

On the Dataset Page, Filter Tags and File Types containing Spaces #5972

djbrooke opened this issue Jun 26, 2019 · 7 comments · Fixed by #5973

Comments

@djbrooke
Copy link
Contributor

Tags and File Types with spaces aren't being filtered. This was patched in dataverse.harvard.edu this evening. In filesFragment.xhtml, we need to change:

<f:param name="fileTag" value="#{facetLabel.name}"/>
to
<f:param name="fileTag" value='"#{facetLabel.name}"'/>

and

<f:param name="fileTypeGroupFacet" value="#{facetLabel.name}"/>
to
<f:param name="fileTypeGroupFacet" value='"#{facetLabel.name}"'/>

@kcondon
Copy link
Contributor

kcondon commented Jun 27, 2019

Tested, works.

@umuchlish
Copy link
Contributor

Hi All, Does this error also related to this issue? Thanks a bunch. Usman.

Subject metadata: Forest Management & Restoration (FMR)

dataverse-4.15\logs\server.log:
Search Syntax Error: Error from server at http://localhost:8983/solr/collection1: org.apache.solr.search.SyntaxError: Cannot parse 'subject_ss:"Forest Management ': Lexical error at line 1, column 31. Encountered: after : ""Forest Management "]]

@pdurbin
Copy link
Member

pdurbin commented Jul 2, 2019

@umuchlish I believe your issue might be different. I wonder if the "&" is causing you trouble. Can you please give us step by step instructions on how to reproduce the error you're seeing?

@umuchlish
Copy link
Contributor

Hi @pdurbin, I am not sure what triggered the Error, it's just appear after I finished the upgrade process.

@umuchlish
Copy link
Contributor

Thanks Phil. I found the culprit, its came from the API Search request without encode the & symbol.

@pdurbin
Copy link
Member

pdurbin commented Jul 8, 2019

@umuchlish do you have a fix then? If so, is it a code change? Or something we should document in the guides?

@umuchlish
Copy link
Contributor

No Need Phil, its from external request that triggered by project website.

Thank you Phil.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants