Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanup: remove DatasetfieldDefaultValue and DefaultValueSet #9039

Open
bencomp opened this issue Oct 8, 2022 · 1 comment
Open

Code cleanup: remove DatasetfieldDefaultValue and DefaultValueSet #9039

bencomp opened this issue Oct 8, 2022 · 1 comment
Labels
Component: Code Infrastructure formerly "Feature: Code Infrastructure" Feature: None No user-facing feature in particular Type: Suggestion an idea User Role: Hackathon Participant Core developers, frequent contributors, drive-by contributors, etc.

Comments

@bencomp
Copy link
Contributor

bencomp commented Oct 8, 2022

Overview of the Feature Request
I suggest to remove the classes DatasetfieldDefaultValue and DefaultValueSet and references to these classes, because they appear to be unused.

What kind of user is the feature intended for?
Developer

What inspired the request?
As I'm trying to add unit tests that test the very core data model, I came across these classes that are only referenced from DatasetFieldType and themselves. As far as I can tell without any documentation in the code, there is no interaction with these entities from the UI or the API.
The idea to add unit tests came from @pdurbin – because without them, it's hard to refactor.
In the end, Hacktoberfest inspired me to see if I could contribute a little to Dataverse.

What existing behavior do you want changed?
If my analysis is correct, removing these would not change any behaviour.

Any related open or closed issues to this feature request?
I suggested removing a few other classes in #9009.
My first reference to code quality, including documentation, was probably #775.

@sekmiller is the author of these classes; @landreev may also be interested in cleaning up.

@pdurbin pdurbin added Type: Suggestion an idea Component: Code Infrastructure formerly "Feature: Code Infrastructure" User Role: Hackathon Participant Core developers, frequent contributors, drive-by contributors, etc. Feature: None No user-facing feature in particular labels Oct 8, 2023
@bencomp
Copy link
Contributor Author

bencomp commented Jun 18, 2024

Can be closed by #9932

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Code Infrastructure formerly "Feature: Code Infrastructure" Feature: None No user-facing feature in particular Type: Suggestion an idea User Role: Hackathon Participant Core developers, frequent contributors, drive-by contributors, etc.
Projects
None yet
Development

No branches or pull requests

2 participants