Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/148 Extend MissionOverviewValues screen contents #158

Merged
merged 4 commits into from
Apr 4, 2024

Conversation

FranciscoRossoR
Copy link
Contributor

Added the complete text to Mission, Overview and Values sections in the corresponding screen.

@FranciscoRossoR FranciscoRossoR added the bug Something isn't working label Mar 26, 2024
@FranciscoRossoR FranciscoRossoR self-assigned this Mar 26, 2024
@fracalrod3 fracalrod3 self-requested a review March 27, 2024 10:45
Copy link
Collaborator

@claugp06 claugp06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The screen does not look that good. It is tru that the info of one of the containers it is much more and so it is show like that. Think on some other way so that it is shown better (summarise a bit also)

@fracalrod3 fracalrod3 changed the title fix: Extend MissionOverviewValues screen contents fix/148 Extend MissionOverviewValues screen contents Mar 27, 2024
Copy link
Contributor

@fracalrod3 fracalrod3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The values part is awfully long, either shorten it or change the screen's look to make it more appealing and easy to read.

You could try maybe putting another image below mission and vision and adding the values part just under it, for example.

@FranciscoRossoR
Copy link
Contributor Author

Updated styles so the third container appears under the other ones in this screen.

@FranciscoRossoR FranciscoRossoR linked an issue Apr 3, 2024 that may be closed by this pull request
Copy link
Collaborator

@claugp06 claugp06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving the container down makes that visually it looks better. Also, nice job checking that the containers are responsive for different screen sizes

Copy link
Contributor

@fracalrod3 fracalrod3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks a lot better now, greatly done!

@claugp06 claugp06 merged commit 394d112 into develop Apr 4, 2024
1 check passed
@claugp06 claugp06 deleted the fix/148-mission-view-values branch April 4, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Fix/147- mission, view and values
3 participants