Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/171 registration of families #208

Merged
merged 27 commits into from
Apr 20, 2024

Conversation

manbarjim2
Copy link
Contributor

@manbarjim2 manbarjim2 commented Apr 13, 2024

Once a user has registered and has the family role, they are redirected to the forms corresponding to the family. There are two forms, one with the children's data and the other with the family's data.

@manbarjim2 manbarjim2 added the enhancement New feature or request label Apr 13, 2024
@manbarjim2 manbarjim2 added this to the Sprint 3 milestone Apr 13, 2024
@manbarjim2 manbarjim2 linked an issue Apr 13, 2024 that may be closed by this pull request
Copy link
Contributor

@marnunrey2 marnunrey2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I manage to do the registration of the user and the family was created on the api but when I try to login it says: "No active account found with the given credentials". but I checked and the user is enabled, so I think there's something wrong with your code. After checking I think you should take a look at how the voluntario login is done and try to do something similar

Copy link
Collaborator

@claugp06 claugp06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to register as a family and activate the account but when I try to log in it is not working

@claugp06 claugp06 self-requested a review April 18, 2024 13:40
Copy link
Collaborator

@claugp06 claugp06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried again and still the same error
image

@manbarjim2
Copy link
Contributor Author

There are two issues for this branch related to backend:

  1. Family does not have a status to go from WAITING to ACCEPTED.

  2. And also when you register as a family, it automatically assigns you a familyId so it is never null.

@claugp06
Copy link
Collaborator

There are two issues for this branch related to backend:

  1. Family does not have a status to go from WAITING to ACCEPTED.
  2. And also when you register as a family, it automatically assigns you a familyId so it is never null.

The registration of a family it is always accepted the NGO does not accepted them, what they accept is the kids not the family itself, whay you need to do is to created the form to complete the date needed for been a family and thats all

@claugp06
Copy link
Collaborator

There are two issues for this branch related to backend:

  1. Family does not have a status to go from WAITING to ACCEPTED.
  2. And also when you register as a family, it automatically assigns you a familyId so it is never null.

The registration of a family it is always accepted the NGO does not accepted them, what they accept is the kids not the family itself, whay you need to do is to created the form to complete the date needed for been a family and thats all

And also the form to register as a child, right?

That's already done in the pull request of @Ahydul in the kids part I think

I saw it, in this issue we were also doing it but I just deleted it to leave only his.

The idea of this issue was to create the form for the families maybe was my bad

Copy link
Collaborator

@claugp06 claugp06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the conflicts errors that appears

Copy link
Collaborator

@claugp06 claugp06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to do the register and the form needed to complete the family registration it is shown (maybe add a tittle or some info saying that some info it is needed it) but when I press send it gives this error
image
Have you include the tokens?

Copy link
Collaborator

@claugp06 claugp06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works now (well done) but just two small details:

  1. The password should not be needed it in that form
  2. I have this alert message that appear after the success
    image
    If you want to show some error/sucess message use toast please

Copy link
Collaborator

@claugp06 claugp06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a tittle to the form ann instead of "apellido 1" use "primer apellido". Also, I introduced the data and press send and I was redirect but given an error message

Copy link
Collaborator

@claugp06 claugp06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A toast message of succes it not shown, also consider using a whole new screen without headers and side menu for showing the register form of family and once it is done redirect to "niños" insteas of profile

claugp06
claugp06 previously approved these changes Apr 20, 2024
Copy link
Collaborator

@claugp06 claugp06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems good now

marnunrey2
marnunrey2 previously approved these changes Apr 20, 2024
Copy link
Contributor

@marnunrey2 marnunrey2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, it works!

Copy link
Contributor

@marnunrey2 marnunrey2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still works, well done!

Copy link
Collaborator

@claugp06 claugp06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems everthing it is ok and good job with the conflicts

@manbarjim2 manbarjim2 merged commit 2a6c7b6 into develop Apr 20, 2024
1 check passed
@manbarjim2 manbarjim2 deleted the feature/171-registration-of-families branch April 20, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature/171-Registration of families
4 participants