Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: log in redirections #213

Merged
merged 3 commits into from
Apr 19, 2024
Merged

Fix: log in redirections #213

merged 3 commits into from
Apr 19, 2024

Conversation

claugp06
Copy link
Collaborator

The redirections after log in have been fixing. Now, the user should be redirect to their screen without the need of refreshing manually. I have use context from react instead of the local storage

@claugp06 claugp06 added the bug Something isn't working label Apr 19, 2024
@claugp06 claugp06 added this to the Sprint 3 milestone Apr 19, 2024
@claugp06 claugp06 self-assigned this Apr 19, 2024
@claugp06 claugp06 linked an issue Apr 19, 2024 that may be closed by this pull request
Fix/212- Log In token #212
Closed
FelixoGudiel
FelixoGudiel previously approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@FelixoGudiel FelixoGudiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. Logged in as a family, logged out, logged in as a volunteer, as another family and such. Really nice work!

manbarjim2
manbarjim2 previously approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@manbarjim2 manbarjim2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I logged in as a volunteer, family, social and educator and everything was correct. Good job!

FranciscoRossoR
FranciscoRossoR requested changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@FranciscoRossoR FranciscoRossoR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I log in with a family account right after validating the account via the link sent by email, I can log in perfectly, but when I log out and try to log in again I get a "No active account found with the given credentials" message.

@claugp06
Copy link
Collaborator Author

When I log in with a family account right after validating the account via the link sent by email, I can log in perfectly, but when I log out and try to log in again I get a "No active account found with the given credentials" message.

I will have a look thanks for the heads up. I will try the same as you and see if i get the same problem

@claugp06 claugp06 dismissed stale reviews from manbarjim2 and FelixoGudiel via d6efc01 April 19, 2024 13:08
FranciscoRossoR
FranciscoRossoR approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@FranciscoRossoR FranciscoRossoR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I can correctly log in with a family account, well done.

manbarjim2
manbarjim2 approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@manbarjim2 manbarjim2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct!

@manbarjim2 manbarjim2 merged commit a12b27b into develop Apr 19, 2024
1 check passed
@manbarjim2 manbarjim2 deleted the fix/212-logInToken branch April 19, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FranciscoRossoR FranciscoRossoR FranciscoRossoR approved these changes

@manbarjim2 manbarjim2 manbarjim2 approved these changes

@FelixoGudiel FelixoGudiel Awaiting requested review from FelixoGudiel

Assignees

@claugp06 claugp06

Labels
bug Something isn't working
Projects
None yet
Milestone
Sprint 3
Development

Successfully merging this pull request may close these issues.

Fix/212- Log In token
4 participants
@claugp06 @FelixoGudiel @manbarjim2 @FranciscoRossoR