Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/161 payment system #224

Merged
merged 12 commits into from
Apr 21, 2024
Merged

Feature/161 payment system #224

merged 12 commits into from
Apr 21, 2024

Conversation

claugp06
Copy link
Collaborator

Now punctual donations can be pay by card

@claugp06 claugp06 added the enhancement New feature or request label Apr 21, 2024
@claugp06 claugp06 added this to the Sprint 3 milestone Apr 21, 2024
@claugp06 claugp06 self-assigned this Apr 21, 2024
@claugp06 claugp06 linked an issue Apr 21, 2024 that may be closed by this pull request
Feature/161-Payment system #161
Closed
FelixoGudiel
FelixoGudiel reviewed Apr 21, 2024
View reviewed changes
Copy link
Contributor

@FelixoGudiel FelixoGudiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works, but could you add a validator for the email and the quantity?

FelixoGudiel
FelixoGudiel approved these changes Apr 21, 2024
View reviewed changes
Copy link
Contributor

@FelixoGudiel FelixoGudiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

FranciscoRossoR
FranciscoRossoR approved these changes Apr 21, 2024
View reviewed changes
Copy link
Contributor

@FranciscoRossoR FranciscoRossoR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both the task and the validators work, well done.

@claugp06 claugp06 merged commit 76516c2 into develop Apr 21, 2024
1 check passed
@claugp06 claugp06 deleted the feature/161-payment-system branch April 21, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FranciscoRossoR FranciscoRossoR FranciscoRossoR approved these changes

@FelixoGudiel FelixoGudiel FelixoGudiel approved these changes

Assignees

@claugp06 claugp06

Labels
enhancement New feature or request
Projects
None yet
Milestone
Sprint 3
Development

Successfully merging this pull request may close these issues.

Feature/161-Payment system
6 participants
@claugp06 @FelixoGudiel @FranciscoRossoR @fracalrod3 @MartaInes @ivaramlar